CDRIVER-4394 add decimal128 Range Index tests#1192
Closed
kevinAlbs wants to merge 6 commits intomongodb:masterfrom
Closed
CDRIVER-4394 add decimal128 Range Index tests#1192kevinAlbs wants to merge 6 commits intomongodb:masterfrom
kevinAlbs wants to merge 6 commits intomongodb:masterfrom
Conversation
libmongocrypt's build will fetch and build the version of libbson.
Enables libmongocrypt to find the version of cmake it needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*-csetasks from clang 3.4 Ubuntu 14.04 variant.Background & Motivation
Use of compile.sh
The C driver currently builds libmongocrypt by invoking
cmakedirectly incompile-unix.shandcompile-windows.sh. mongodb/libmongocrypt#522 (comment) notes the required version of cmake to build libmongocrypt is cmake will soon be 3.12.0. The C driver builds with older versions of cmake in some distros. libmongocrypt'sensure-cmake.shscript ensures the presence of a CMake executable matching a specific version. Therefore, this PR proposes building libmongocrypt using thecompile.shscript. Usingcompile.shis currently done in the Go driver.Removal of
*-csetasks from clang 3.4 Ubuntu 14.04Removal of
*-csetasks from clang 3.4 Ubuntu 14.04 variant is motivated by an observed compiler error for the libmongocrypt C++ tests (described mongodb/libmongocrypt#522 (comment)). libmongocrypt does not build on Ubuntu 14.04. Ubuntu 14.04 does not support server versions >= 4.2. Server version 4.2 is the minimum required for CSFLE support.